Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: Updated order controller and controller advice and added tests #137

Open
wants to merge 1 commit into
base: feat/added-bean-validation-to-order-dtos
Choose a base branch
from
Open

update: Updated order controller and controller advice and added tests #137

wants to merge 1 commit into from

Conversation

koreanMike513
Copy link
Collaborator

  • order controller 및 order controller advice를 bean validation 을 반영하여 업데이트하였습니다.
  • order controller test를 추가하였습니다.

@koreanMike513 koreanMike513 added the enhancement New feature or request label Feb 24, 2025
@koreanMike513 koreanMike513 self-assigned this Feb 24, 2025
@github-actions GitHub Actions
Copy link

HCP Terraform Plan Output

```
Plan: 35 to add, 0 to change, 0 to destroy.
```
[HCP Terraform Plan](https://app.terraform.io/app/Joyeuse_Planete/workspaces/Joyeuse_Planete/runs/run-WKauFPrSgzUCLmk6)

f-lab-troy
f-lab-troy approved these changes Feb 25, 2025
View reviewed changes
orders/src/main/java/com/f_lab/joyeuse_planete/orders/controller/GlobalExceptionHandler.java
@ExceptionHandler(MethodArgumentNotValidException.class)
public ResponseEntity<ResultResponse> handle(MethodArgumentNotValidException e) {
LogUtil.exception("GlobalExceptionHandler.handle (MethodArgumentNotValidException)", e);
StringBuilder sb = new StringBuilder();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stream, join등을 통해 간결하게 표현하는 방법이 있는지 알아보면 좋습니다.

orders/src/test/java/com/f_lab/joyeuse_planete/orders/controller/OrderControllerTest.java
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(OrderController.class)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 test coverage report 생성 및 리뷰를 추천드립니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-troy f-lab-troy f-lab-troy approved these changes

Assignees

@koreanMike513 koreanMike513

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koreanMike513 @f-lab-troy