Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added bean validation to order dtos #136

Open
wants to merge 1 commit into
base: feat/added-food-controller-advice-and-updated-controller
Choose a base branch
from
Open

feat: Added bean validation to order dtos #136

wants to merge 1 commit into from

Conversation

koreanMike513
Copy link
Collaborator

  • order project 에서의 request body 및 request param 검증을 위해서 bean validation 을 추가하였습니다.

@koreanMike513 koreanMike513 added the enhancement New feature or request label Feb 24, 2025
@koreanMike513 koreanMike513 self-assigned this Feb 24, 2025
@github-actions GitHub Actions
Copy link

HCP Terraform Plan Output

```
Plan: 35 to add, 0 to change, 0 to destroy.
```
[HCP Terraform Plan](https://app.terraform.io/app/Joyeuse_Planete/workspaces/Joyeuse_Planete/runs/run-mKmLDhVdr19FHUgt)

f-lab-troy
f-lab-troy approved these changes Feb 25, 2025
View reviewed changes
orders/src/main/java/com/f_lab/joyeuse_planete/orders/dto/request/OrderSearchCondition.java
}

@AssertTrue(message = BeanValidationErrorMessage.INVALID_DATE_RANGE_ERROR_MESSAGE)
public boolean isStartDateEarlierThanEndDate() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier/Before등 같은 의미의 단어는 하나로 통합하는게 좋습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-troy f-lab-troy f-lab-troy approved these changes

Assignees

@koreanMike513 koreanMike513

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koreanMike513 @f-lab-troy