feat: Added payment mvc (토스) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
koreanMike513
commented
Feb 16, 2025
koreanMike513
commented
- 토스의 결제 흐름에 따라 success url 과 fail url 을 추가하였습니다.
HCP Terraform Plan Output |
f-lab-troy
approved these changes
Feb 18, 2025
| // "https://api.tosspayments.com/v1/payments/confirm" 에 결제성공 로직 구현 | ||
| } catch (Exception e) { | ||
| LogUtil.exception("PaymentService.processPaymentSuccess", e); | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
넵 현재는 비동기를 적용하여 exception을 적용하도록 해두었습니다.
| try { | ||
| kafkaService.sendKafkaEvent(PAYMENT_PROCESS_EVENT, event); | ||
| } catch(Exception e) { | ||
| LogUtil.exception("PaymentService.sendKafkaEvent", e); |
There was a problem hiding this comment.
이것도 오래 생각을 해보았는데 여기서 예외를 던져버리면 모든 transaction이 rollback 이 되어버리기 때문에 로깅 처리만 하고 재시도 로직은 카프카 dead letter topic queue 에서 처리되게 하는 것이 맞다고 생각하여 이렇게 처리하였습니다.
koreanMike513
added
the
partially_resolved (requires a another review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.