-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow commas in tel URIs #388
Comments
Sure, send a patch. |
danbrellis
added a commit
to danbrellis/htmlpurifier
that referenced
this issue
Nov 10, 2023
ezyang
pushed a commit
that referenced
this issue
Nov 10, 2023
github-actions bot
pushed a commit
that referenced
this issue
Nov 17, 2023
# [4.17.0](v4.16.0...v4.17.0) (2023-11-17) ### Bug Fixes * CSSTidy ImportantComments not handled properly ([#359](#359)) ([78a9b4d](78a9b4d)) * fix CI ([#361](#361)) ([9ec687c](9ec687c)) * Invalid scheme check in Attr.TargetBlank ([#363](#363)) ([0176ef4](0176ef4)) * semantic release ([#339](#339)) ([d82f3d9](d82f3d9)) * semantic release ([#341](#341)) ([e55fead](e55fead)), closes [#339](#339) * Support for locales using decimal separators other than . (dot) ([#372](#372)) ([43f49ac](43f49ac)) ### Features * Add support for all text-decoration properties ([#360](#360)) ([2d775c0](2d775c0)) * Allows commas to be included in tel URI ([#389](#389)) ([ec92490](ec92490)), closes [#388](#388) ### Reverts * Revert "fix: semantic release (#339)" (#340) ([3e83215](3e83215)), closes [#339](#339) [#340](#340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At least here in the U.S., dialing a comma in a phone number indicates a puase of a few seconds. As a result, often video conference call-in numbers will include a comma in the dial-in number before the passcode to save the caller from having to dial in the passcode separately.
However, the current implementation of the tel URIScheme strips out everything other than numbers,
x
, and a leading+
. Thus:<a href="tel:+12029910477,,32288696#">+1 202-991-0477,,32288696#</a>
is formatted to
<a href="tel:+1202991047732288696#">+1 202-991-0477,,32288696#</a>
which results in a wrong number dialed.
Does it make sense to allow commas in numbers? And/or can someone advise on how to override that regex?
The text was updated successfully, but these errors were encountered: