store can not be called here, because it clears object's data_map

[SerheyDolgushev]

For example we have a content class, which consist of following attributes:

• attribute 1 (any datatype)
  ...
• attribute 10 (any datatype)
• attribute 11 (objectrelation list datatype)
• attribute 12 (any datatype)
  ...
• attribute 20 (any datatype)

When new content object of this type is published (without any relations in attribute 11). Its datatype cache will be cleared. And it will be not possible to get valid objects datamap in attribute 12 ... attribute 20.

Current changes fixes this bug.

[bdunogier]

Looks legit. Gotta say I'd really appreciate if there was a test covering this case. I'll check this out.

[SerheyDolgushev]

I found this issue with custom datatype, which was using objects data map in fetchObjectAttributeHTTPInput method. Sorry, im not sure, if some build-in datatypes are using object data map in fetchObjectAttributeHTTPInput.

[glye]

Did you verify that only this datatype does this?
It does look weird that it only calls setContent() and store() when the list is empty.

Is the docblock wrong too, then?
Fetches the http post var string input and stores it in the data instance.

[SerheyDolgushev]

@glye

Did you verify that only this datatype does this?

To be honest, I do not remember, but most likely "yes" is the answer

Is the docblock wrong too, then?

Seems like it is

At any rate, is there a chance this PR will be merged? Or should we just wisely close it?

[glye]

It seems sensible. But finding the time to verify it is the problem. We need to at least compare with other datatypes.

[glye]

Now I feel bad 😃 I had a look at some other datatypes, and the PR seems correct. If you reopen it I will merge.

[SerheyDolgushev]

I was unable to reopen this one, as the source branch was removed some time ago. So I made #1455.