Fix handling of headings in table header cells #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version is set to 2019.99-alpha1 as there isn't plans atm for what next feature release will be if any, if there is needs for another feature release community would need to drive that. <ad> With eZ Platform 2.5LTS being out and bringing more or less feature parity with eZ Publish it's a good time to evaluate it again. With legacy bridge support it's also a good version to migrate to if you have legacy needs. Or if you are a developer then eZ Platform 3 comming this year might be of interest for new projects, as one of it's core aims is to greatly improve developer experience, closer integrate the CMS with Symfomny & lots more. </ad> Thanks for all the fish, I mean legacy!
* Popup for the custom tag sub/sup fixed * Update extension/ezoe/design/standard/templates/ezoe/tag_custom.tpl Co-Authored-By: André R. <andre.romcke@gmail.com>
Only check cache generation timeout when generation has actually started. Avoids SQL error.
This reverts commit 98b8f48.
…partial URL alias path (ezsystems#1437)
…zsystems#1455) eZObjectRelationList: Do not store the content object attribute in the fetch call, because it clears the object's data_map, which means other content object attributes cannot access the data map.
|
I was able to confirm the behaviour. I had to disable the editor in order to change the cells to . |
andrerom
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add heading element inside the regular table cell (td), it will be correctly applied, stored and displayed on the frontend.
If you try to do the same inside table header cell (th), after you store the changes, the heading will get moved from the header cell and placed below the table.
This PR fixes the incorrect behaviour.