EZP-29279: Values of Date Field Type should be handled in UTC only #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbieniek
requested review from
andrerom,
glye,
vidarl and
kmadejski
and removed request for
vidarl
1 task
glye
approved these changes
Nov 29, 2018
|
Thanks @glye! DataTime has different JIRA issue and I will be creating similar PR for it after this one is done ¯_(ツ)_/¯ |
glye
reviewed
Nov 29, 2018
…add more s p a c e s to the same class code
kmadejski
approved these changes
Nov 30, 2018
kmadejski
approved these changes
Nov 30, 2018
lib/ezutils/classes/eztimestamp.php
Outdated
| $localDate = new \DateTime( $utcDate->format( 'Y-m-d H:i:s' ), $localTimezone ); | ||
| $localTimestamp = $localDate->getTimestamp(); | ||
|
|
||
| return $localTimestamp; |
There was a problem hiding this comment.
Maybe you should do it like:
$localDate = new \DateTime( $utcDate->format( 'Y-m-d H:i:s' ), $localTimezone );
return $localDate->getTimestamp();
or even:
return new \DateTime( $utcDate->format( 'Y-m-d H:i:s' ), $localTimezone )->getTimestamp();
but I prefer the first way, it's more readable.
The same applies for https://github.com/ezsystems/ezpublish-legacy/pull/1401/files/6b98fbe6e7b1c9e93bbf6b42a1d00205f42705bd#diff-9ae7112c632bad6c06997d57aefd6f82R24.
There was a problem hiding this comment.
You are right! I prefer the first approach as well. Fixed.
|
Script for updating DB: |
andrerom
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: EZP-29279
Replaces #1384
Currently, in Legacy, the timestamp stored in the database is always midnight in the server's timezone, while in Platform it is always in UTC.
This PR modifies
eZDateTypeclass so timestamps are converted to UTC before being stored and are converted back to Local Timezone timestamp on retrieval.