Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29350: Make query compatible with strict MySQL #1368

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

omh
Copy link
Contributor

@omh omh commented Jun 5, 2018

MySQL 5.7 is strict by default and will error out on the incorrect GROUP BY in the update script (see diff).

MySQL 5.7 is strict by default and will error out on the incorrect GROUP BY.
@andrerom andrerom requested a review from alongosz June 28, 2018 12:44
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, good catch!

@omh
Copy link
Contributor Author

omh commented Jun 28, 2018

@omh omh changed the title Make query compatible with strict MySQL EZP-29350: Make query compatible with strict MySQL Jun 28, 2018
@andrerom andrerom merged commit 28fadf9 into ezsystems:master Jun 29, 2018
andrerom pushed a commit that referenced this pull request Jun 29, 2018
MySQL 5.7 is strict by default and will error out on the incorrect GROUP BY.

(cherry picked from commit 28fadf9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants