Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29351: Fixed fatal error #1367

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

omh
Copy link
Contributor

@omh omh commented Jun 5, 2018

continue used outside of loop.

`continue` used outside of loop.
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, should also be backported to 5.4

@andrerom andrerom requested a review from konradoboza June 28, 2018 12:46
@andrerom
Copy link
Contributor

@omh Could you create jira issues for the PR's you have done the last month?

@andrerom andrerom merged commit 582e393 into ezsystems:master Jun 28, 2018
@omh
Copy link
Contributor Author

omh commented Jun 28, 2018

@andrerom Done!

Issue: https://jira.ez.no/browse/EZP-29351

Do you want me to get my colleagues (Rune, Jørgen, Elise) to do the same?

@omh omh deleted the omh-fatal-error-update-script branch June 28, 2018 13:37
@omh omh changed the title Fixed fatal error EZP-29351: Fixed fatal error Jun 28, 2018
@andrerom
Copy link
Contributor

Do you want me to get my colleagues (Rune, Jørgen, Elise) to do the same?

For anything affecting prior releases, yes ideally we would want that for change logs.

andrerom pushed a commit that referenced this pull request Jun 29, 2018
`continue` used outside of loop.

(cherry picked from commit 582e393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants