Fix EZP-26209: Textline legacy search indexing causes TransactionError

[blankse]

Alternative to #1268

[blankse]

@andrerom I create the PR without your nitpic.

[andrerom]

+1, but @alongosz; any input on if the max and min is within what most SQL engines support (given this is on generic interface).

[alongosz]

Seems like most reasonable limit supported by every DBMS out-of-the-box.

However these should be constants IMHO // cc @andrerom

[blankse]

@alongosz I changed it to constants

[pkamps]

It's probably OK to use const. But in the unlikely case we would support a DBMS with different values for max/min integers we probably have a hard time to overwrite that value in a child class for that DBMS.
https://stackoverflow.com/questions/13613594/overriding-class-constants-vs-properties

[alongosz]

@pkamps I wouldn't recommend overriding it at all as it would cause issues for data migrations between systems.
2^31 is a reasonable value that is supported by most of the DBMS-es if not all of them.

But if you really want to override it later, then property is also bad choice because those values are constant with respect to DBMS, not db handler instance. In this case introducing a method, e.g. getMaxInt would make more sense.

[andrerom]

+1, but @pkamps are you fine with this? As stated above different lengths depending on sql engine will be an issue as well that blows up the complexity (for data migrations) vs use here as far as I can see.

[pkamps]

+1
I'm convinced, it's very unlikely to have different int max/min values.

[gggeek]

If going for a const, I vote for naming it MAX_INT_32BIT, so that it is slightly more clear what is intended purpose and origin are. Fe. it makes it easier to add later MAX_INT_64BIT and have code which uses the latter...

As a complement of info

• php MAX_INT is already 64 bit almost everywhere (even on windows) and hence can not be used
• all dbs supported by eZ also use 64 bits for ints and have done that since dawn of time
• only 'db' that I know of currently stuck on 32bit land is Solr