EZP-31930: Cleaned up output of commands displaying progress bar #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up output showing a progress bar for the following commands: * ezplatform:install * ezplatform:reindex
alongosz
force-pushed
the
fix-7.5/fix-ezplatform-install-progress-bar
branch
from
c7850ef to
d53cfd4
Compare
6 tasks
lserwatka
approved these changes
Oct 22, 2020
adamwojs
approved these changes
Oct 22, 2020
ViniTou
approved these changes
Oct 23, 2020
bogusez
approved these changes
Oct 23, 2020
alongosz
added a commit
to ezsystems/ezplatform
that referenced
this pull request
Oct 23, 2020
Applied ANSI style to Symfony commands executed via `composer ezplatform-install`. For more details please see ezsystems/ezpublish-kernel#3070 and #597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5,ezplatform-kernel:1.1,ezplatform-kernel:masterTL;DR;
Cleaned up output showing a progress bar for the following commands:
to resolve issues discovered in ezsystems/ezplatform#597
Summary
This is an attempt to further cleanup output of commands used by
composer ezplatform-installwith ANSI mode. While ANSI solves most important issues, sometimes ProgressBar gets randomly repeated after a command finishes execution and next output appears (either terminal prompt or from chained next command), as can be seen ezsystems/ezplatform#597 (comment)The issues occurring are not deterministic and the fix is a result of trial & error approach.
Known issues
Sometimes the progress bar of
ezplatform:reindexeither disappears or shows 0%. Seems it's a random race issue due to small volume of data and the operation being too quick for terminal buffer to adjust.TODO:
Implement tests.// covered implicitly by every behat scenario$ composer fix-cs).