EZP-31681: Proposed changes to ezsystems/ezpublish-kernel/pull/3060 #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Sep 25, 2020
| } else { | ||
| @trigger_error( | ||
| \sprintf( | ||
| 'In eZ Platform 2.5 and 3.x %s should implement %s. ' . |
There was a problem hiding this comment.
Maybe instead of that we should think about moving toHash method to \eZ\Publish\SPI\FieldType\Value?
4 tasks
|
Closing as it was incorporated into #3060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ezsystems:EZP-31681This PR better describes my proposed changes from the review #3060 (review) for #3060.
I've re-used Comparable but moved it to be a part of FieldType, not Value, since the necessary logic lays in the FT impl.
I've also added BC layer for non-core FTs (all core ones automatically use Comparable implemented on Core abstract FT).
TODO:
Comparable::valuesEqual