Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed comparator function in LocationServiceTest::testLoadLocationsContent #3064

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Fixed comparator function in LocationServiceTest::testLoadLocationsContent #3064

merged 2 commits into from
Sep 16, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 14, 2020 •
edited
Loading

Question Answer
JIRA issue -
Bug/Improvement yes
New feature no
Target version 6.13+
BC breaks no
Tests pass yes
Doc needed no

More details: https://sonarcloud.io/project/issues?id=ezsystems_ezplatform-kernel&open=AXRxrZNpKN6oSq4n8nbG&resolved=false&types=BUG

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs added the Bug label Sep 14, 2020
@adamwojs adamwojs self-assigned this Sep 14, 2020
ViniTou
ViniTou reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the tests were passing anyway? Should we then add something to be sure that this sort is indeed used or not.

I assume the failing travis build (php5.6) is related to #3063 ?

@adamwojs
Copy link
Member Author

I assume the failing travis build (php5.6) is related to #3063 ?

yes, we can wait for #3063 merge to be pass CI.

@adamwojs adamwojs force-pushed the missing_strcmp_val_ret branch from 0a80dda to 0b6a433 Compare September 16, 2020 07:20
@adamwojs adamwojs merged commit daa76b8 into 6.13 Sep 16, 2020
@adamwojs adamwojs deleted the missing_strcmp_val_ret branch September 16, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@kaff kaff Awaiting requested review from kaff

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@adamwojs adamwojs

Labels
Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwojs @alongosz @ViniTou