Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31584: Created LocationResolver service which provides first available Location #3050

Merged
merged 5 commits into from
Jul 29, 2020

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jul 24, 2020

Question Answer
JIRA issue EZP-31584
Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

When loading Relation main Location might not be accessible for the end-user due to permissions which results in Unauthorized Exception even though the user can have access to different Locations of this Relation.

Related admin-ui PR: ezsystems/ezplatform-admin-ui#1439

TODO:

  • Implement improvement.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 self-assigned this Jul 24, 2020
@barw4 barw4 requested review from alongosz and mikadamczyk July 27, 2020 13:18
@micszo micszo self-assigned this Jul 28, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.12 with diffs for main problem.
There are other places which result in 403 (Relations tab, Search) or Unauthorised (UDW).
Will create separate tickets shortly.

@micszo
Copy link
Member

micszo commented Jul 28, 2020

UDW part: https://jira.ez.no/browse/EZP-31776

@micszo
Copy link
Member

micszo commented Jul 28, 2020

Part for twigs: https://jira.ez.no/browse/EZP-31777

@lserwatka lserwatka merged commit 08bd2de into 7.5 Jul 29, 2020
@lserwatka lserwatka deleted the EZP-31584 branch July 29, 2020 12:17
@barw4
Copy link
Member Author

barw4 commented Jul 29, 2020

@micszo micszo removed their assignment Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants