-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Travis] Fixed REST tests failing for PHP < 7.3 #2909
[Travis] Fixed REST tests failing for PHP < 7.3 #2909
Conversation
Seems 5.6 is running into memory:
|
@mnocon How about running temporarily tests with committed composer.lock? Just to see if on 5.6 it's still working. Final solution should use PHP 7.1 then. |
Passing job on 5.6: https://travis-ci.org/ezsystems/ezpublish-kernel/jobs/634269119 (with composer.lock) (Solr job failed because the dependency is not added when running with lock). I will rework this PR to use PHP7.1 now. |
The REST functional tests job in ezplatform-http-cache is failing: https://travis-ci.org/ezsystems/ezplatform-http-cache/jobs/626775072
This is caused by the usage of heredoc syntax that has been allowed only since PHP 7.3:
https://www.php.net/manual/en/migration73.new-features.php#migration73.new-features.core.heredoc
This PR:
TO DO (before merge):
Remove TMP before mergingNotes:
TODO:
$ composer fix-cs
).