EZP-31258: Use "inset" for "scaledown" aliases to avoid undesired image cropping #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Dec 30, 2019
peterkeung
force-pushed
the
EZP-31258-image_alias_inset
branch
from
9243e36 to
dedc6ec
Compare
|
Rebase on 6.13 branch complete |
konradoboza
approved these changes
Dec 31, 2019
|
Target changed |
|
I agree with the PR changes, IMHO image cropping is undesired in "scaledown" aliases. I'm only afraid that some projects might rely on current behavior (dimensions of result image), so we should document upgrade steps. Small comparison:
|
adamwojs
approved these changes
Jan 7, 2020
alongosz
approved these changes
Jan 7, 2020
@adamwojs In this particular case, given the example you've shown I cannot imagine someone expecting this buggy behavior ;) |
I mean the dimensions of the resulting image, not cropping (sorry for not being precise) 😛 |
micszo
approved these changes
Jan 20, 2020
|
@alongosz could you merge this up? |
|
Thank you @peterkeung 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.13All "scaledown" aliases (https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Bundle/EzPublishCoreBundle/Resources/config/image.yml#L174) are using the "outbound" thumbnail mode. This is because the Liip thumbnail filter loader is expecting the text "inset" (https://github.com/liip/LiipImagineBundle/blob/master/Imagine/Filter/Loader/ThumbnailFilterLoader.php#L25) instead of "ImageInterface::THUMBNAIL_INSET" (https://github.com/ezsystems/ezpublish-kernel/blob/7.5/eZ/Bundle/EzPublishCoreBundle/Imagine/Filter/Loader/ScaleWidthDownOnlyFilterLoader.php#L30). As a result, the image aliases are subject to undesirable cropping.