Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Travis] Fix memory issues during build #2869

Merged
merged 3 commits into from
Nov 27, 2019
Merged

[Travis] Fix memory issues during build #2869

merged 3 commits into from
Nov 27, 2019

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Nov 12, 2019 •
edited
Loading

Question Answer
JIRA issue https://jira.ez.no/browse/EZP-31189
Bug/Improvement no
New feature no
Target version 6.7, 6.13 -> swap is not required for 7.5 and master and as it takes time we shouldn't use it where it's not necessary
BC breaks no
Tests pass yes
Doc needed no

Travis is failing because of memory issues, this PR:

  1. Reduces memory required by Composer by adding a branch alias to the PR dependency and bumping minimal Symfony requirements
  2. Sets up swap to increase the memory available to Composer and sets memory_limit=-1

alongosz
alongosz reviewed Nov 26, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@mnocon mnocon changed the title [WIP] [Travis] Bumped minimal supported Symfony 3 version [WIP] [Travis] Fix memory issues during build Nov 27, 2019
@mnocon mnocon changed the title [WIP] [Travis] Fix memory issues during build [Travis] Fix memory issues during build Nov 27, 2019
alongosz
alongosz requested changes Nov 27, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one more request:

bin/.travis/enable_swap.sh Show resolved Hide resolved
@mnocon @alongosz
Update bin/.travis/enable_swap.sh
6406ea5 
Co-Authored-By: Andrew Longosz <alongosz@users.noreply.github.com>
@mnocon
Copy link
Member Author

mnocon commented Nov 27, 2019

@alongosz I've applied your remark

micszo
micszo approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with this!

@alongosz alongosz merged commit 44fa432 into ezsystems:6.7 Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggeek gggeek gggeek left review comments

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@m-tyrala m-tyrala m-tyrala approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mnocon @gggeek @alongosz @micszo @m-tyrala @katarzynazawada