-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-30823: [7.x] Isolated cache during transactions to avoid race condition #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
alongosz
changed the title
EZP-30823: [7.x] Isolate cache during transactions to avoid race condition
EZP-30823: [7.x] Isolated cache during transactions to avoid race condition
Sep 10, 2019
alongosz
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks:
eZ/Publish/Core/Persistence/Cache/Adapter/TransactionalInMemoryCacheAdapter.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Cache/Adapter/TransactionalInMemoryCacheAdapter.php
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Cache/Adapter/TransactionalInMemoryCacheAdapter.php
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Cache/Adapter/TransactionalInMemoryCacheAdapter.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Cache/Adapter/TransactionalInMemoryCacheAdapter.php
Outdated
Show resolved
Hide resolved
andrerom
force-pushed
the
EZP-30823_7.5_transaction_cache_isolation
branch
2 times, most recently
from
September 23, 2019 08:39
fcac772
to
82ceaf6
Compare
Co-Authored-By: Andrew Longosz <alongosz@users.noreply.github.com>
andrerom
force-pushed
the
EZP-30823_7.5_transaction_cache_isolation
branch
from
September 24, 2019 10:46
10fc790
to
df6464c
Compare
@webhdx What's your POV/Review here? |
webhdx
approved these changes
Sep 30, 2019
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5
+, but depends on #2740 being merged first as this is for conflict resolution during mergeDuring attempt to backport the transaction isolation fixes done in #2703 a few cases where we should go a bit further appeared:
REVIEW NOTES:
REVIEW QUESTION:
ezpublish.cache_pool.inner
and instead remove the decoration?