EZP-30635: Fixed infinite loop in Reindex Command on the last iteration #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
force-pushed
the
reindexer_issue_on_fork
branch
from
8aa6ffe to
a3c7a7a
Compare
adamwojs
reviewed
Jun 7, 2019
| @@ -387,6 +389,10 @@ private function fetchIteration(Statement $stmt, $iterationCount) | |||
| */ | |||
| private function getPhpProcess(array $contentIds, $commit) | |||
| { | |||
| if (empty($contentIds)) { | |||
| throw new RuntimeException("'--content-ids=' can not be empty on parallel sub process"); | |||
There was a problem hiding this comment.
InvalidArgumentException seems to be a better choice here.
There was a problem hiding this comment.
@adamwojs InvalidArgumentException should be used when the argument is not of an expected type, but here we expect array and an array it is, but empty. I think that RuntimeException is ok.
There was a problem hiding this comment.
I think @adamwojs is right here, both exception about --iteration-count and this one should rather use InvalidArgumentException or InvalidArgumentValue exception. (among those I also prefer InvalidArgumentException here as it makes it possible to say what is wrong)
ok @mateuszbieniek and @adamwojs ?
There was a problem hiding this comment.
Updated in 6b2f78f
mateuszbieniek
approved these changes
Jun 7, 2019
kmadejski
approved these changes
Jun 11, 2019
alongosz
changed the title
alongosz
approved these changes
Jun 11, 2019
adamwojs
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.7When content-count % iteration-count === 0, aka when last iteration would have empty results, there would be faulty call to with empty ´--content-ids=´ causing whole new index process to start again with purge and everything.
TODO:
$ composer fix-cs).