EZP-30547: As a Developer I'd like to be able to debug config resolver & services #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
force-pushed
the
config_debug_commands
branch
from
25a5e9a to
a4dd59a
Compare
adamwojs
reviewed
May 12, 2019
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
andrerom
force-pushed
the
config_debug_commands
branch
4 times, most recently
from
0b905b7 to
fd68caa
Compare
|
@adamwojs Updated FYI: I assumed you implied it should now be on it's own line given we use dump |
mateuszbieniek
requested changes
May 21, 2019
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
andrerom
force-pushed
the
config_debug_commands
branch
from
fd68caa to
eaf629c
Compare
kmadejski
approved these changes
May 21, 2019
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
adamwojs
approved these changes
May 21, 2019
Thanks @kmadejski 👍 😃 |
alongosz
previously requested changes
May 22, 2019
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
alongosz
reviewed
May 28, 2019
There was a problem hiding this comment.
Hi. Sorry for a long delay.
About #2635 (comment) - ok, but maybe let's split it to a separate PR? It might require tweaking for Symfony4 as it would become not much usable.
eZ/Bundle/EzPublishCoreBundle/Command/DebugConfigResolverCommand.php
Outdated
Show resolved
Hide resolved
Co-Authored-By: Kamil Madejski <kmadejski@live.com>
andrerom
force-pushed
the
config_debug_commands
branch
from
662e8f0 to
13fd589
Compare
|
@alongosz Updated, command is now a service Same goes for you @mateuszbieniek, your remarks should be solved by now. |
mateuszbieniek
approved these changes
Jun 11, 2019
alongosz
approved these changes
Jun 11, 2019
|
Need this in helping debug some on-going config resolver issues on multi site config setup, so merging for testing to be done pre-release with the other relevant config resolver changes to help detect these issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.7(given these can be useful for support)Commands to be able to debug config resolver and services, as used on #2634 to verify that issue was not config resolver but rather early loaded service.
Useful both for debug (especially in support case) use cases, but also for doc / training use cases to verify configuration steps have been completed ok.
TODO:
$ composer fix-cs).