Add missing read only properties to role structs

[emodric]

These should be readable. As far as I can see, there's no way to access limitations and policies once added to structs, there's no abstract methods to implement like, for example, eZ\Publish\API\Repository\Values\User\Role::getPolicies

[andrerom]

One minor mistake with the protected stuff I have been made aware of during the conference is that you can not change the array, as it is returned by value and not by reference.

Code:

class Test
{
    protected $test = array( 'one' );
    function __get( $name ){ return $this->$name; }
    function __set( $name, $value ){ $this->$name = $value; }
}

$obj = new Test();

var_dump( $obj->test );

$obj->test[] = 'two';

var_dump( $obj->test );

$obj->test[0] = 'oneTwo';

var_dump( $obj->test );

Output:

array(1) {
  [0]=>
  string(3) "one"
}

Notice: Indirect modification of overloaded property Test::$test has no effect in /Users/andrerom/Sites/www/next/index.php on line 63

Call Stack:
    0.0019     653336   1. {main}() /Users/andrerom/Sites/www/next/index.php:0

array(1) {
  [0]=>
  string(3) "one"
}

Notice: Indirect modification of overloaded property Test::$test has no effect in /Users/andrerom/Sites/www/next/index.php on line 67

Call Stack:
    0.0019     653336   1. {main}() /Users/andrerom/Sites/www/next/index.php:0

array(1) {
  [0]=>
  string(3) "one"
}

If this is annoying enough to need methods, I don't know. As they are readonly they are not supposed to be manipulated like this anyway.

[emodric]

Sounds good to me. I'll make another commit to add methods. But, how should we stop exposing arrays? Throwing exceptions in __get in case is_array returns true?

[andrerom]

Throwing exceptions in __get in case is_array returns true?

No, I think the possible outcome is to either remove all magic and instead have clear methods in the interface for readonly properties. Or let it be like it is.

[emodric]

It seems kinda too much to have methods for each and every readonly property, some value objects have 5 and more of those.

[andrerom]

Yes, and that is why we ended up with these magic methods instead.

[andrerom]

The diff looks good now, so good that I can start to nitpick :)

1. 3 x remaining unneeded new lines in class php doc headers
2. 3 x "public abstract function getLimitations();" should be "abstract public function getLimitations();"

[emodric]

The diff looks good now, so good that I can start to nitpick :)

:))

1. 3 x remaining unneeded new lines in class php doc headers

Removed the lines in PHPDoc comments.

1. 3 x "public abstract function getLimitations();" should be "abstract public function getLimitations();"

I wrote those exactly as existing methods addLimitation / addPolicy :)

[emodric]

Rebased the pull request with current master for "abstract public"