Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] EZP-32103: Adjusted Behat config to behave more like prod #621

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Nov 4, 2020

JIRA: https://issues.ibexa.co/browse/EZP-32103

Contains #623 and temp changes, needs rebase before merging.

Things done:

  1. I've removed the default config from FriendsOfBehat\SymfonyExtension

We're using the default values for the kernel class and path. The env and debug value is taken from the loaded bootstrap file, which loads environmental variables - there's no change in behaviour if APP_ENV=behat, APP_DEBUG=1 is specified (which we do in all our builds) and it's not harcoded there in case someone wants to change it.

  1. I've adjusted behat env configuration to be more prod-like: right now it contains all the files from prod env, reasoning: our tests should be running in a similar env as the production one (but with Debug enabled, so that errors are not silenced). I've also enabled strict_requirements for routing: https://symfony.com/doc/current/reference/configuration/framework.html#strict-requirements to make sure we're not silencing any errors. I had to do it because HTTP cache behaves in a weird way when framework.test setting is enabled - IMHO it's a good opportunity to decide how the behat env should behave.

@mnocon mnocon force-pushed the EZP-32103-add-varnish-integration-tests branch from 135df39 to 8bd4f9d Compare November 6, 2020 12:37
@mnocon mnocon force-pushed the EZP-32103-add-varnish-integration-tests branch from 8bd4f9d to 15dc2e0 Compare November 6, 2020 18:12
@mnocon mnocon force-pushed the EZP-32103-add-varnish-integration-tests branch 4 times, most recently from 692beef to cfcabbf Compare November 17, 2020 19:19
@mnocon mnocon changed the title [Docker] EZP-32103: Added app container to varnish debuggers [Docker] EZP-32103: Adjusted Behat config to behave more like prod Nov 18, 2020
@mnocon mnocon changed the title [Docker] EZP-32103: Adjusted Behat config to behave more like prod [Tests] EZP-32103: Adjusted Behat config to behave more like prod Nov 18, 2020
@mnocon mnocon marked this pull request as ready for review November 19, 2020 08:54
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the direction for behat env - prod-like with errors exposed.

@mnocon mnocon force-pushed the EZP-32103-add-varnish-integration-tests branch from dd2f8b0 to 23f2758 Compare November 19, 2020 11:50
@micszo micszo merged commit 2222297 into 3.1 Nov 19, 2020
@micszo micszo deleted the EZP-32103-add-varnish-integration-tests branch November 19, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants