-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-27458: Add Field Facet Visitor #129
Conversation
This comment has been minimized.
This comment has been minimized.
We would somehow need to make sure we have integration tests in kernel, but besides that Looks like good direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, indeed some integration test in ezpublish-kernel explaining what happens here would be nice.
Though I see we have some integration tests, which use FieldFacetBuilder
, in \eZ\Publish\API\Repository\Tests\SearchServiceTest
so I wonder how do they work (maybe there were skipped, or just don't throw when missing builder?).
Anyway this PR will require either more investigation by me before I approve or more explaining in PhpDoc, because code is not self-explanatory.
pinging also our foremost expert in faceted search - @Nattfarinn - for a review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the nitpicks some comments.
Though I see we have some integration tests, which use FieldFacetBuilder, in \eZ\Publish\API\Repository\Tests\SearchServiceTest so I wonder how do they work (maybe there were skipped, or just don't throw when missing builder?).
Afaik skipped, but we should check that they pass here. Ideally Solr tests should be setup to fail on skips to avoid any silent skips happening.
Follow up kernel API design considerations
(NOTE to self / @alongosz, and possibly you @wizhippo if you're up for it)
Besides the need to better document fieldPaths
and FieldRangeFacetBuilder->fieldPath
:
It seems Solr does not allow for regex like the way it's suggested in API. Maybe we should deprecate it, and maybe also consider to add the following if it translates well to Elastic too:
- (string)
prefix
- (string)
contains
- (bool)
containsIgnoreCase
= false
Any chance the v3 is coming up we can visit this and facets? |
ping @SylvainGuittard |
@alongosz I am not against having this in v3. |
@SylvainGuittard Someone in eZ Eng needs to write integration tests in kernel, besides that we are more or less good to go here. |
Superseded by ezsystems/ezplatform-kernel#94 |
Add filed facet support
Example
Related PR ezsystems/ezpublish-kernel#2557