Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2973: Remove obsolete random sleep on REST login #95

Merged
merged 1 commit into from
Jun 2, 2022
Merged

IBX-2973: Remove obsolete random sleep on REST login #95

merged 1 commit into from
Jun 2, 2022

Conversation

glye
Copy link
Member

@glye glye commented Jun 1, 2022 •
edited
Loading

Question Answer
JIRA issue EZP-2973
Type improvement
Target version Ibexa DXP v3.3
BC breaks no
Tests pass 1 failure, timeout
Doc needed no

Remove the small amount of random sleep on REST login that was made unnecessary with the release of https://issues.ibexa.co/browse/IBX-1755

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@glye
Copy link
Member Author

glye commented Jun 1, 2022 •
edited
Loading

That one test has timed out 3 times now, so it seems permanent. But I don't see how it could relate to the code change.

@glye glye requested review from barw4 and a team June 1, 2022 14:13
Steveb-p
Steveb-p approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeout for the failing job should be increased in a separate PR.

We're hitting the composer process timeout of 5 minutes.

@glye glye merged commit 222894e into 1.3 Jun 2, 2022
@glye glye deleted the ibx2973-remove-random-sleep branch June 2, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@barw4 barw4 barw4 approved these changes

@ViniTou ViniTou ViniTou approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glye @Steveb-p @ViniTou @barw4 @konradoboza @alongosz