Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31359: Common content http cache tag abstractions #115

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Feb 5, 2020

Question Answer
JIRA issue EZP-31359
Type Bug/Improvement
Target version 0.9 In order to provide future compatibility for page builder and others
BC breaks no
Doc needed yes, but better if this is done together with the other changes done in 1.0

Exposes abstractions and constants for the content tag prefixes which are the once documented to be used externally.

NB: I on purpose did not use the new constant in Slots here, I'll adapt 1.0 and the corresponding master branch for that instead, less conflicts.

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@andrerom andrerom requested review from adamwojs and ViniTou February 5, 2020 14:09
@andrerom
Copy link
Contributor Author

andrerom commented Feb 6, 2020

Merging, testing will be done against 1.0/master branch and upcoming page filed type patch to use this.

@andrerom andrerom merged commit e08dc6f into 0.9 Feb 6, 2020
@andrerom andrerom deleted the common_content_tag_abstractions branch February 6, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants