Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31108: Use code style rules from ezplatform-code-style #108

Merged
merged 2 commits into from
Nov 27, 2019
Merged

EZP-31108: Use code style rules from ezplatform-code-style #108

merged 2 commits into from
Nov 27, 2019

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue EZP-31108
Type Misc
Target version latest stable
BC breaks no
Doc needed no

Imported code style rules from ezplatform-code-style and applied to the current codebase.

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs self-assigned this Nov 27, 2019
@adamwojs adamwojs requested review from andrerom, alongosz and kmadejski and removed request for andrerom November 27, 2019 11:19
@adamwojs adamwojs mentioned this pull request Nov 27, 2019
Merged
5 tasks
@adamwojs adamwojs merged commit 22f1a12 into 0.9 Nov 27, 2019
@adamwojs adamwojs deleted the updated_cs branch November 27, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmadejski kmadejski kmadejski approved these changes

@alongosz alongosz alongosz approved these changes

@andrerom andrerom Awaiting requested review from andrerom

Assignees

@adamwojs adamwojs

Labels
Improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwojs @alongosz @kmadejski