IBX-1085: Skipped schema generation for invalid Image Variation #108
+60
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprecated (unused)
…rding to GraphQL spec)
…er as deprecated (unused)
adamwojs
changed the title
alongosz
requested changes
Oct 18, 2021
Steveb-p
approved these changes
Oct 18, 2021
alongosz
approved these changes
Oct 18, 2021
Steveb-p
reviewed
Oct 18, 2021
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
ciastektk
approved these changes
Oct 18, 2021
kacper-wieczorek-ibexa
approved these changes
Oct 20, 2021
|
Good for me. Note that this should be documented ! Maybe in the image variation doc ? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Waiting for merge up for #109 merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @bdunogier we should skip schema generation for invalid Image Variation (according to GraphQL spec) and emit warning to logs (and console output):