Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31986: Added missing RuntimeException import to CompileAssetsCommand #20

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 15, 2020

Question Answer
JIRA issue EZP-31986
Bug/Improvement yes
New feature no
Target version 1.0
BC breaks no
Tests pass yes
Doc needed no

Follow up for #19 . Currently ezplatform:encore:compile throws

In CompileAssetsCommand.php line 82:
!!                                                                                 
!!    Attempted to load class "RuntimeException" from namespace "EzSystems\EzPlat  
!!    formEncoreBundle\Command".                                                   
!!    Did you forget a "use" statement for e.g. "Webimpress\SafeWriter\Exception\  
!!    RuntimeException", "Symfony\Component\Yaml\Exception\RuntimeException", "Sy  
!!    mfony\Component\Validator\Exception\RuntimeException", "Symfony\Component\T  
!!    ranslation\Exception\RuntimeException", "Symfony\Component\String\Exception  
!!    \RuntimeException", "Symfony\Component\Serializer\Exception\RuntimeExceptio  
!!    n", "Symfony\Component\Security\Core\Exception\RuntimeException", "Symfony\  
!!    Component\PropertyAccess\Exception\RuntimeException", "Symfony\Component\Pr  
!!    ocess\Exception\RuntimeException", "Symfony\Component\Mime\Exception\Runtim  
!!    eException", "Symfony\Component\Intl\Exception\RuntimeException", "Symfony\  
!!    Component\Form\Exception\RuntimeException", "Symfony\Component\DependencyIn  
!!    jection\Exception\RuntimeException", "Symfony\Component\Console\Exception\R  
!!    untimeException", "SensioLabs\Security\Exception\RuntimeException", "Pagerf  
!!    anta\Exception\RuntimeException", "Laminas\EventManager\Exception\RuntimeEx  
!!    ception", "Laminas\Code\Exception\RuntimeException", "Laminas\Code\Generato  
!!    r\Exception\RuntimeException", "Laminas\Code\Reflection\Exception\RuntimeEx  
!!    ception", "JMS\TranslationBundle\Exception\RuntimeException", "JMS\Serializ  
!!    er\Exception\RuntimeException" or "Imagine\Exception\RuntimeException"?      
!!                                                                                 

when subprocess execution failed. Correct output is

 An error occurred when executing the "yarn encore dev" command:              
!!                                                                                 
!!    yarn run v1.3.2                                                              
!!    $ /home/awojs/eZ/ezplatform-sf-recipies/node_modules/.bin/encore dev         
!!    Running webpack ...                                                          
!!                                                                                 
!!     ERROR  Failed to compile with 1 errors2:28:20 PM                            
!!                                                                                 
!!     ....
!!               
!!    (node:14554) [DEP0005] DeprecationWarning: Buffer() is deprecated due to se  
!!    curity and usability issues. Please use the Buffer.alloc(), Buffer.allocUns  
!!    afe(), or Buffer.from() methods instead.                                     
!!    error Command failed with exit code 2.  

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs self-assigned this Oct 15, 2020
@adamwojs adamwojs added the Bug Something isn't working label Oct 15, 2020
@adamwojs adamwojs requested a review from lserwatka October 15, 2020 12:35
@lserwatka lserwatka merged commit 3b18532 into 1.0 Oct 15, 2020
@lserwatka lserwatka deleted the ezp-31986-follow_up branch October 15, 2020 12:48
@lserwatka
Copy link
Member

You can merge it up.

@adamwojs
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants