Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed class definition to span multiple lines #15

Merged
merged 1 commit into from
Aug 21, 2021
Merged

Allowed class definition to span multiple lines #15

merged 1 commit into from
Aug 21, 2021

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue N/A
Type improvement
Target package version ?
BC breaks no
Doc needed no

As in title. Some classes in our codebase implement multiple interfaces, which causes line length to exceed the soft limit.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Steveb-p Steveb-p requested review from adamwojs, alongosz and a team July 29, 2021 11:51
@Steveb-p Steveb-p requested a review from a team July 29, 2021 12:47
@Steveb-p Steveb-p merged commit 6a41208 into master Aug 21, 2021
@Steveb-p Steveb-p deleted the class_definition branch August 21, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steveb-p @adamwojs @alongosz @ViniTou