-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-28127: Create extendable left sidebar #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
approved these changes
Oct 25, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9314604 looks good. Note that I'm not familiar with KnpMenu, so commenting "code-wise" only ;)
As for the PR about the top menu, having howtos for the feature would be very helpful. Could you add that, even if it is just a draft in the PR's description for the time being ? |
lserwatka
approved these changes
Oct 26, 2017
Nattfarinn
approved these changes
Oct 26, 2017
This was referenced Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reimplements left sidebar (which is visible in Location View and Trash) using
knplabs/knp-menu-bundle
package. I also created extensibility point based on events.Developers can take advantage of
ConfigureMenuEvent::CONTENT_SIDEBAR_LEFT
event to make customization to the sidebar i.e. reorder, add or remove items. Code snippets on how to customize sidebar are available at #26 as managing sidebar items uses the same approach.All items are styled by default, more advanced buttons can use custom attributes as shown below: