Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-154: Allowed to define if the alternative text for image field is required (2.5) #1782

Merged
merged 5 commits into from
Jun 25, 2021
Merged

IBX-154: Allowed to define if the alternative text for image field is required (2.5) #1782

merged 5 commits into from
Jun 25, 2021

Conversation

adamwojs
Copy link
Member

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-154
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? ?
License GPL-2.0

#1777 for v2.5

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs changed the title IBX-154: Allowed to define if the alternative text for image field is required IBX-154: Allowed to define if the alternative text for image field is required (2.5) Jun 16, 2021
@adamwojs adamwojs self-assigned this Jun 16, 2021
@adamwojs adamwojs requested a review from a team June 17, 2021 11:42
@piotrbisaga piotrbisaga self-assigned this Jun 21, 2021
@piotrbisaga
Copy link
Contributor

At first glance I saw that new checkbox "alternative text is required" is not written with bold when comparing it to "required" and "translatable"
Screenshot 2021-06-22 at 09 08 51

@adamwojs
Copy link
Member Author

@piotrbisaga fbe6173 should fix this inconsistency

@piotrbisaga
Copy link
Contributor

Please take a look at the below described output after performing 2/4 possible options in Jira

1/
On the left nr2: image field required and alternative text required
On the right nr4: image filed not required and alternative text required

Comparison only to highlight difference in exclamation mark colour and difference between validating errors.

2/
After applying step nr4: uploaded image disappears right after clicking "Upload file"

Screenshot 2021-06-22 at 13 10 13

@dew326 dew326 requested review from GrabowskiM and tischsoic June 24, 2021 11:37
@dew326 dew326 self-assigned this Jun 24, 2021
piotrbisaga
piotrbisaga approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@piotrbisaga piotrbisaga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved, checked on eZ Platform Enterprise 2.5 with .diff

@piotrbisaga piotrbisaga removed their assignment Jun 24, 2021
@adamwojs adamwojs merged commit dc28cf0 into 1.5 Jun 25, 2021
@adamwojs adamwojs deleted the ibx_154_25 branch June 25, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@piotrbisaga piotrbisaga piotrbisaga approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@adamwojs adamwojs

@dew326 dew326

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamwojs @piotrbisaga @Steveb-p @alongosz @ViniTou @lserwatka @dew326