[EZP-32397] Removed logic from ezdate.html.twig #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbieniek
force-pushed
the
EZP-32397_fix
branch
from
547e1ce to
c328b74
Compare
konradoboza
approved these changes
Mar 31, 2021
adamwojs
approved these changes
Apr 1, 2021
Comment on lines
10
to
13
| {% set action_type = | ||
| app.request.attributes.get('_route') is same as('ez_content_draft_edit') or | ||
| app.request.attributes.get('_route') is same as('ezplatform.content.translate') ? 'edit' : 'create' | ||
| %} |
There was a problem hiding this comment.
You can use in operator here:
app.request.attributes.get('_route') in ['ez_content_draft_edit', 'ezplatform.content.translate']
but TBH this logic should be placed in form value mapper or / Form type buildView method rather then in Twig template
|
Moved logic from template: ezsystems/repository-forms#344 |
mateuszbieniek
changed the title
mateuszbieniek
changed the title
konradoboza
approved these changes
Apr 6, 2021
mateuszdebinski
approved these changes
Apr 6, 2021
ViniTou
approved these changes
Apr 12, 2021
adamwojs
approved these changes
Apr 13, 2021
|
QA approved. |
|
@mateuszbieniek could you merge it up? |
|
Merged up to |
|
|
|
and |
lucasOsti
pushed a commit
to lucasOsti/ezplatform-admin-ui
that referenced
this pull request
Apr 28, 2021
* Added condition for content.translate in edit/ezdate.html.twig * Changes after CR#1 * Dropped merging attr * Revert removing attrbiutes mergin from the view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires: ezsystems/repository-forms#344
This PR removes logic from the template https://github.com/ezsystems/ezplatform-admin-ui/blob/v1.5.17/src/bundle/Resources/views/fieldtypes/edit/ezdate.html.twig#L10 as it is no longer needed (see ezsystems/repository-forms#344)
Checklist:
$ composer fix-cs)