Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32311: Dropdown bottom options become inaccessible inside modals #1709

Merged
merged 3 commits into from
Feb 22, 2021
Merged

EZP-32311: Dropdown bottom options become inaccessible inside modals #1709

merged 3 commits into from
Feb 22, 2021

Conversation

konradoboza
Copy link
Member

Question Answer
Tickets EZP-32311
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

JIRA excerpt:

When a Create a new translation window is shown and more than 6 Languages are defined, some of them won't be visible in the "Select a language for the new translation" field.

The idea is to check whether any of the dropdown parents is a modal (not to break dropdowns outside popups) and reduce the dropdown's height to not exceed the modal's height. Thanks to that, a scroll will appear allowing the user to select bottom options that are currently being covered by the modal itself.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza self-assigned this Feb 18, 2021
@konradoboza konradoboza requested a review from dew326 February 19, 2021 07:29
@konradoboza konradoboza removed their assignment Feb 19, 2021
@tomaszszopinski tomaszszopinski self-assigned this Feb 22, 2021
tomaszszopinski
tomaszszopinski approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 3.2.4 with diff & patch.

@lserwatka lserwatka merged commit d6a6551 into 2.2 Feb 22, 2021
@lserwatka lserwatka deleted the ezp-32311-too-long-modal-dropdowns branch February 22, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

Assignees

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@konradoboza @dew326 @lucasOsti @tomaszszopinski @lserwatka