EZP-32179: Add footer to platform when user is logged in #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
EZP-32179-Add-footer-to-platform-when-user-is-logged-in
branch
from
101d45e to
a34a5f2
Compare
dew326
requested changes
Jan 21, 2021
| @@ -189,3 +209,40 @@ select { | |||
| padding: 0; | |||
| } | |||
| } | |||
|
|
|||
| .ez-footer { | |||
| <trans-unit id="ad4e634b7a562503b6e50d2b057490b8d7dc6336" resname="role.policy.siso_control_center.all_functions"> | ||
| <source>Siso control center / All functions</source> | ||
| <target>Siso control center / All functions</target> | ||
| <note>key: role.policy.siso_control_center.all_functions</note> |
There was a problem hiding this comment.
This probably should not be removed. It will remove translations in policy select.
cc @mikadamczyk
lucasOsti
force-pushed
the
EZP-32179-Add-footer-to-platform-when-user-is-logged-in
branch
from
e8ac0b5 to
620cee0
Compare
GrabowskiM
requested changes
Jan 21, 2021
| @@ -145,6 +146,25 @@ select { | |||
| background-color: $ibexa-color-base-pale; | |||
| } | |||
|
|
|||
| .ez-info-view, | |||
There was a problem hiding this comment.
Personally I would add new single class to css and add this class to html instead of styling by all these 20 classes
| @@ -0,0 +1,11 @@ | |||
| <div class="ez-footer"> | |||
| <div class="ez-footer__brand-container"> | |||
| <img class="ez-footer__brand-img" src="/bundles/ezplatformadminui/img/ibexa-wordmark.svg" alt="Ibexa" /> | |||
There was a problem hiding this comment.
alt with no trans
Should I translate name of company?
GrabowskiM
approved these changes
Jan 25, 2021
dew326
approved these changes
Jan 25, 2021
dew326
approved these changes
Jan 26, 2021
GrabowskiM
approved these changes
Jan 27, 2021
GrabowskiM
approved these changes
Jan 27, 2021
dew326
approved these changes
Jan 27, 2021
bogusez
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)