Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31983: Catched exception thrown by empty tab group #1551

Merged
merged 2 commits into from
Oct 6, 2020
Merged

EZP-31983: Catched exception thrown by empty tab group #1551

merged 2 commits into from
Oct 6, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 2, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-31983
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou requested a review from adamwojs October 5, 2020 07:29
@micszo micszo self-assigned this Oct 5, 2020
micszo
micszo approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified together with ezsystems/ezplatform-ee#156.

@micszo micszo removed their assignment Oct 6, 2020
@adamwojs adamwojs merged commit c8c1ead into 1.5 Oct 6, 2020
@adamwojs adamwojs deleted the empty-tab-group branch October 6, 2020 09:46
@adamwojs
Copy link
Member

adamwojs commented Oct 6, 2020

Could you please merge up changes @ViniTou?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@adamwojs adamwojs adamwojs approved these changes

@kaff kaff kaff approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@alongosz alongosz Awaiting requested review from alongosz

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViniTou @adamwojs @kaff @micszo