Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Added sorting subitems by Modified date before navigating #1479

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Sep 10, 2020

Question Answer
Tickets https://jira.ez.no/browse/EZP-31839
Bug fix? yes (in tests)
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Please see Jira issue for a list of failing builds.

Sometimes our tests are unable to find a Content Item when navigating through subitems - I suspect this is a similar issue to #1184 , where the list of Subitems is modified by Scenarios running in parallel.

This solution sorts the Subitems by Modification date (descending), hoping that the item the tests are looking for is created recently and will be displayed on the first page - and when it's on the first page of results then any modifications are not able to interfere with it, as it's already displayed.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mnocon mnocon changed the title [WIP] [Behat] Added sorting subitems by Modified date before navigating [Behat] Added sorting subitems by Modified date before navigating Sep 10, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot.

@micszo micszo merged commit bde2148 into 1.5 Sep 11, 2020
@micszo micszo deleted the EZP-31839-add-sort-by-in-subitems branch September 11, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants