[Behat] Added possibility to read browser logs multiple times #1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Description
According to Selenium doc (https://github.com/SeleniumHQ/selenium/wiki/Logging#retrieval-of-logs):
It's not possible to retrieve the same log multiple times. As this is the approach used in ezsystems/allure-behat#10 I had to introduce a "cache" layer that allows to read the same log entries twice (but no more 😉 ).
There is also one small change: Webdriver can return
null
when the session is not started yet, this case is now handled.To do before merging: