Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Added possibility to read browser logs multiple times #1347

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Apr 14, 2020

Question Answer
Tickets https://jira.ez.no/browse/EZP-31453
Bug fix? no
New feature? yes (for tests)
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Notes

Description

According to Selenium doc (https://github.com/SeleniumHQ/selenium/wiki/Logging#retrieval-of-logs):

In the scenario where a log is retrieved several times the same log entries should not be retrieved more than once. 
For this reason, and to same memory, after each retrieval of a log the log buffer of that log is reset.

It's not possible to retrieve the same log multiple times. As this is the approach used in ezsystems/allure-behat#10 I had to introduce a "cache" layer that allows to read the same log entries twice (but no more 😉 ).

There is also one small change: Webdriver can return null when the session is not started yet, this case is now handled.

To do before merging:

  • Rebase with 1.5 to resolve CS issue
  • Remove TMP commit

@mnocon mnocon changed the title [WIP] Add attachments [WIP] [Behat] Add attachments to Allure Reports Apr 15, 2020
@mnocon mnocon changed the title [WIP] [Behat] Add attachments to Allure Reports [Behat] Add attachments to Allure Reports Apr 15, 2020
@mnocon mnocon changed the title [Behat] Add attachments to Allure Reports [DON"T MERGE] [Behat] Added possibility to read browser logs multiple times Apr 15, 2020
@mnocon mnocon changed the title [DON"T MERGE] [Behat] Added possibility to read browser logs multiple times [DON'T MERGE] [Behat] Added possibility to read browser logs multiple times Apr 15, 2020
@mnocon mnocon changed the title [DON'T MERGE] [Behat] Added possibility to read browser logs multiple times [Behat] Added possibility to read browser logs multiple times Apr 17, 2020
@micszo micszo merged commit f1e7f28 into 1.5 Apr 17, 2020
@micszo micszo deleted the add-attachments branch April 17, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants