EZP-31339: Dropped default config enforcement for ContentTree parser #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Jan 30, 2020
adamwojs
approved these changes
Jan 30, 2020
mateuszbieniek
approved these changes
Jan 30, 2020
webhdx
approved these changes
Jan 30, 2020
micszo
approved these changes
Jan 30, 2020
|
Could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature of ConfigResolver the site access specific config is resolved before the group's one which is valid behavior, however, in certain cases when SemanticConfig is being built it forces the default values to be taken in consideration for specific site access and there is no fallback to group config, even though there should be one.
Checklist:
$ composer fix-cs)