Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Added waiting until RichText toolbar transition ends #1166

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Dec 19, 2019

Question Answer
Tickets https://jira.ez.no/browse/EZEE-2944
Bug fix? in tests
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Tests error:

        Exception: element click intercepted: Element <button class="ae-button ez-btn-ae ez-btn-ae--unordered-list " tabindex="-1" title="List">...</button> is not clickable at point (150, 346). Other element would receive the click: <div class="ez-richtext-tools">...</div>

          (Session info: chrome=74.0.3729.169)

          (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.4.0-101-generic x86_64) in vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:144

AlloyEditor toolbar has a transition that takes 0.15s to finish: https://github.com/liferay/alloy-editor/blob/v1.5.21/src/ui/react/src/assets/sass/components/ae-toolbar/structure.scss#L17 and it looks to me like there is no selector we can wait for to make sure the transition has ended.

There is a class alloy-editor-visible, but it looks like it's added when the trasition starts:
https://github.com/liferay/alloy-editor/blob/v1.5.21/src/ui/react/src/components/base/widget-position.js#L205 (and the ae-toolbar-transition is not removed after the animation finishes).

Adding a sleep time of 200ms to make sure that the transition is over should solve the TextBlock issues we're facing currently.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot.

@micszo micszo merged commit a77e8e0 into 1.5 Dec 20, 2019
@micszo micszo deleted the add-timeout-richtext-toolar branch December 20, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants