[Behat] Added waiting until RichText toolbar transition ends #1166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests error:
AlloyEditor toolbar has a transition that takes 0.15s to finish: https://github.com/liferay/alloy-editor/blob/v1.5.21/src/ui/react/src/assets/sass/components/ae-toolbar/structure.scss#L17 and it looks to me like there is no selector we can wait for to make sure the transition has ended.
There is a class
alloy-editor-visible
, but it looks like it's added when the trasition starts:https://github.com/liferay/alloy-editor/blob/v1.5.21/src/ui/react/src/components/base/widget-position.js#L205 (and the
ae-toolbar-transition
is not removed after the animation finishes).Adding a sleep time of 200ms to make sure that the transition is over should solve the TextBlock issues we're facing currently.
Checklist:
$ composer fix-cs
)