Missing success code for the SystemInfoDumpCommand #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Sep 14, 2020
adamwojs
approved these changes
Sep 14, 2020
Nattfarinn
approved these changes
Sep 14, 2020
andrerom
approved these changes
Sep 14, 2020
micszo
approved these changes
Sep 14, 2020
|
You can merge it up. |
|
Done. |
|
Konrad, is there a Jira ticket for this change? |
|
No there is not. If you need one for the release notes though, I can create it right away. 😉 |
|
We need one. We always need it for release notes. |
|
Here it is: https://jira.ez.no/browse/EZP-31879. |
kacper-wieczorek-ibexa
pushed a commit
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-31879
Symfony 5 commands need to return an exit code that is currently missing. Due to that, the command results in error in eZ Platform 3.1:
Return value of "EzSystems\EzSupportToolsBundle\Command\SystemInfoDumpCommand::execute()" must be of the type int, "null" returned.