Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Composer] Allowed ezpublish-kernel ^7.0 #24

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

alongosz
Copy link
Member

This PR allows ezpublish-kernel:^7.0@dev for ez-support-tools.

Reason: Right now we have to make workaround to install ezplatform:2.0 meta-repository dependencies by setting requirement for ezpublish-kernel in the form of 7.0.x-dev as 6.99.x-dev instead of simply ^7.0@dev. This change solves that partially (see also: ezsystems/ezplatform-http-cache#16).

@andrerom
Copy link
Contributor

+1, but you probably dont need to set dev, as usual that will be set in meta

Copy link
Member

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent space usage compared to the line below, but I don't know which is correct..

@alongosz alongosz changed the title [Composer] Allowed ezpublish-kernel ^7.0@dev [Composer] Allowed ezpublish-kernel ^7.0 Oct 30, 2017
@@ -10,7 +10,7 @@
}
],
"require": {
"ezsystems/ezpublish-kernel": "^6.2",
"ezsystems/ezpublish-kernel": "^6.2 || ^7.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent space usage compared to the line below, but I don't know which is correct..

It seems none :) This probably is due to some changes in composer.json format. Right now doc mentions only double pipe || surrounded by spaces, so I aligned this with it.
Thanks for pointing this out @glye

@alongosz
Copy link
Member Author

@glye @andrerom removed @dev and updated format of version constraint (see comment)

@andrerom andrerom merged commit 18f8d13 into ezsystems:master Oct 30, 2017
@alongosz alongosz deleted the allow-kernel-7.x branch October 30, 2017 16:43
mnocon pushed a commit that referenced this pull request Feb 9, 2022
…24)

* [Rebranding] Expose raw edition identifier getter as a static method

* fix: Coding Standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants