refactor(cache): simplify creating / using the cache var
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
kind: bug
- as everything is created in the `buildStart` hook now (which has `RollupContext`), we can create the `cache` there too
- no need for slightly hacky, lazy creation during `transform` anymore
- simplifies it and also standardizes it so it's created the same way as all the other instance vars
- fix: reset `cache` after each watch cycle
- previously the cache was never reset, meaning that if anything became dirty in a watch cycle, it would never get reset back
- in some cases, this would mean that the cache was effectively always dirty during an entire watch mode run, and therefore never used
- this would be quite inefficient as the FS usage for the cache would just go to waste
- see that test coverage has now increased as a result!
agilgur5
force-pushed
the
refactor-cache-simplify-create
branch
from
2fcae7c
to
0dabda3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is built on top of #414 as it uses thebuildStartchanges made there. As such, I've marked this PR as "Draft" until #414 is merged.Rebased on top and marked as ready for review.
Summary
Use the
buildStarthook added in #414 to simplifycache()tocacheDetails
as everything is created in the
buildStarthook now (which hasRollupContext), we can create thecachethere tootransformanymorefix: reset
cacheafter each watch cycle