refactor: combine check-tsconfig with parse-tsconfig
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
the
kind: internal
|
This is gonna merge conflict with #404 -- please merge that first as it's a complicated one that a bunch of other code depends on |
agilgur5
force-pushed
the
refactor-combine-tsconfig-handlers
branch
2 times, most recently
from
48b7df2
to
f015c78
Compare
agilgur5
force-pushed
the
refactor-combine-tsconfig-handlers
branch
from
f015c78
to
f4535c1
Compare
- `checkTsConfig` is literally only used by `parseTsConfig` - I first just moved the function over, but it's a two-liner, so thought it made more sense to just in-line it - merge the unit tests as well - we already check the non-error case in `parse-tsconfig.spec`, so only add the error case - `check-tsconfig` was longer in the past and more files were being created then for separation, so this may have made more sense then, but now it is unnecessary - c.f. 7332077
agilgur5
force-pushed
the
refactor-combine-tsconfig-handlers
branch
from
f4535c1
to
b7d1bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is built on top of #404 as it uses thecontextchanges made there. As such, I've marked this PR as "Draft" until #404 is merged.Rebased on top and marked as ready for review.
Summary
Combine the two
tsconfigfiles into one as the split is not currently necessary and adds unnecessary complexityDetails
checkTsConfigis literally only used byparseTsConfigmerge the unit tests as well
parse-tsconfig.spec, so only add the error casecheck-tsconfigwas longer in the past and more files were being created then for separation, so this may have made more sense then, but now it is unnecessary