-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dx): remove extra quote in emitDeclarationOnly
log statement
#412
Merged
ezolenko
merged 1 commit into
ezolenko:master
from
agilgur5:fix-dx-extra-quote-emitDeclarationOnly
Aug 25, 2022
Merged
fix(dx): remove extra quote in emitDeclarationOnly
log statement
#412
ezolenko
merged 1 commit into
ezolenko:master
from
agilgur5:fix-dx-extra-quote-emitDeclarationOnly
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- must've been a copy+paste mistake or something
agilgur5
added
scope: docs
Documentation could be improved. Or changes that only affect docs
kind: dx
Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc
labels
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: dx
Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc
scope: docs
Documentation could be improved. Or changes that only affect docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just removes an unnecessary quote
emitDeclarationOnly
in v0.33.0 -- what if I want an empty chunk and only declarations? #411's loggingemitDeclarationOnly
#366Details