Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 100% coverage for tslib.ts (error case) #399

Merged
merged 1 commit into from
Aug 19, 2022
Merged

test: 100% coverage for tslib.ts (error case) #399

merged 1 commit into from
Aug 19, 2022

Conversation

agilgur5
Copy link
Collaborator

Summary

Get to 100% coverage of tslib.ts by adding a check for error case

Details

  • use Jest's module mocks to test the error case of tslib.ts when tslib fails to import
    • this took a bit of work to figure out bc, per the in-line comments, the ordering and module subpath were both required
      • it was pretty confusing for a while until I realized what might be going wrong

@agilgur5
test: 100% coverage for tslib.ts (error case)
c2b6411 
- use Jest's module mocks to test the error case of `tslib.ts` when `tslib` fails to import
  - this took a bit of work to figure out bc, per the in-line comments, the ordering and module subpath were both _required_
    - it was pretty confusing for a while until I realized what might be going wrong
@agilgur5 agilgur5 added kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: tests Tests could be improved. Or changes that only affect tests labels Jul 23, 2022
@agilgur5 agilgur5 mentioned this pull request Jul 23, 2022
Merged
@ezolenko ezolenko merged commit 4e5ab74 into ezolenko:master Aug 19, 2022
@agilgur5 agilgur5 deleted the test-100-tslib-error branch July 2, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: tests Tests could be improved. Or changes that only affect tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilgur5 @ezolenko