Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dx(cache): improve clean edge-case errors with quotes #394

Merged
merged 1 commit into from
Aug 8, 2022
Merged

dx(cache): improve clean edge-case errors with quotes #394

merged 1 commit into from
Aug 8, 2022

Conversation

agilgur5
Copy link
Collaborator

Summary

Add quotes around vars in error messages in the cache's clean method

Details

  • follows the style of most of the other errors in the codebase
    • when referencing a variable, file path, etc, put quotes around it in the output
      • so it's easier to distinguish in the log

@agilgur5
dx(cache): improve clean edge-case errors with quotes
bfab95c 
- follows the style of most of the other errors in the codebase
  - when referencing a variable, file path, etc, put quotes around it in the output
    - so it's easier to distinguish in the log
@agilgur5 agilgur5 added scope: docs Documentation could be improved. Or changes that only affect docs kind: optimization Performance, space, size, etc improvement kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc scope: cache Related to the cache and removed scope: docs Documentation could be improved. Or changes that only affect docs kind: optimization Performance, space, size, etc improvement labels Jul 22, 2022
@ezolenko ezolenko merged commit d17864d into ezolenko:master Aug 8, 2022
@agilgur5 agilgur5 deleted the dx-cache-clean-errors branch July 2, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc scope: cache Related to the cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilgur5 @ezolenko