optim(cache): don't check imports for syntactic diagnostics #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Syntactic diagnostics are only per-file, so we don't need to
checkImports
in the cache'sisDirty
check for themDetails
References
DocumentRegistry
b/t watch cycles #388 .codeCache
in most cases when imports change #369 ; that was a de-opt forcodeCache
, this is an optimization forsyntacticDiagnosticsCache