feat: capture watch mode when called via the Rollup API #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `process.env.ROLLUP_WATCH` is only set when using the CLI - when using watch mode through the Rollup API (https://rollupjs.org/guide/en/#rollupwatch), this is not set - but since Rollup 2.14.0 (https://github.com/rollup/rollup/blob/master/CHANGELOG.md#2140), `this.meta.watchMode` is available - still check the env variable for backward-compat on older Rollup versions - notably, this is needed to test watch mode, since the tests are done via the Rollup API
agilgur5
added
kind: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Capture
this.meta.watchModewhen it is availableDetails
process.env.ROLLUP_WATCHis only set when using the CLIthis.meta.watchModeis availablenotably, this is needed to test watch mode, since the tests are done via the Rollup API