refactor(cache): makeName
-> createHash
for clarity
#355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename
makeName
->createHash
andname
->hash
intscache.ts
code for clarityDetails
I've actually been confused multiple times as to what
makeName
does when I read through the cachecreateHash
would make things a lot clearerName
->Hash
make
->create
because that's the more common terminology in programmingalso rename variables that reference
makeName
's return fromname
tohash
name
can be confusing since we also haveid
, which is a path that is very similar to a name toofileName
s tooMisc Notes
Been digging into cache bugs more now that I've fixed a ton of the non-cache ones, so doing a bit of refactoring here as I'm going through it more frequently and in more depth.