Skip to content

Commit

Permalink
fix: add back noErrors = false to emitSkipped (#381)
Browse files Browse the repository at this point in the history
- apparently `emitSkipped` can indeed happen without there being a semantic or syntactic error
  - so add back the previous unconditional behavior of `noErrors`

- still not clear what exactly triggers `emitSkipped` though, see my TS issue
  • Loading branch information
agilgur5 authored Jul 12, 2022
1 parent 21549dc commit dcae517
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>

if (output.emitSkipped)
{
noErrors = false;
// always checking on fatal errors, even if options.check is set to false
typecheckFile(id, snapshot, contextWrapper);

Expand Down

0 comments on commit dcae517

Please sign in to comment.